Order package manifest to start with the package declaration #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of starting with environment variable parsing, start with the actual package manifest, which is most likely the most interesting to most users.
MahdiBM
reviewed
Jan 25, 2024
There was a problem hiding this comment.
I don't think this is possible to do with simple variables. See: swiftlang/swift#66045
Unless that bug is something even more complicated.
You can, however, use extensions to another type at the end of the file. Then use those declarations that are in the extensions higher up in the package constant.
Member
Author
|
That’s why all the variables are computed instead of stored, to work around the limitations of https://forums.swift.org/t/on-the-behavior-of-variables-in-top-level-code/52230. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of starting with environment variable parsing, start with the actual package manifest, which is most likely the most interesting to most users.
As suggested in #680 (comment).