[6.0.x] Restore URL.host bracket stripping for compatibility #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
parkera
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Strips the square brackets from IP literal hosts when calling
URL.host. This restores previous behavior and prevents bincompat issues for clients who take IPv6 addresses fromURL.hostand pass them directly to APIs likeinet_pton(3).Scope: Only impacts
URL.hostandURL.host()when the host is an IP literal.Original PR: #1008
Risk: Low - Small change to restore previous behavior.
Testing: Added unit test, swift-ci, stable in
mainReviewer: @parkera
Resolves #957 for
release/6.0