Hour-override isn't respected when formatting date #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows 12 hour format)
We wrongly returned the entire pref dictionary instead of the demanded value.
I did not want to spend too much time adding a test since this is dependent on the the autoupdating current locale. I did verify the following test failed before but passed after the fix.
```Obj-C
- (void)test24HourOverride {
NSDateFormatter *formatter = [[NSDateFormatter alloc] init];
[formatter setLocale:[NSLocale autoupdatingCurrentLocale]];
[formatter setLocalizedDateFormatFromTemplate:@"Jmm"];
NSString *dateFormat = formatter.dateFormat;
XCTAssertEqualObjects(dateFormat, @"HH:mm");
}
```
|
@swift-ci please test |
parkera
approved these changes
Oct 26, 2023
|
Linux failure is fixed in swiftlang/swift-syntax#2312 Hopefully we'll get a new snapshot soon |
jmschonfeld
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wrongly returned the entire pref dictionary instead of the demanded value.
I did not want to spend too much time adding a test since this is dependent on the the autoupdating current locale. I did verify the following test failed before but passed after the fix.