Skip to content

Conversation

@jmschonfeld
Copy link
Contributor

@jmschonfeld jmschonfeld commented Jul 17, 2024

We previously reverted some sendable annotations in #679 due to a compiler bug around the IRGen for KeyPath & Sendable parameters. While the compiler bug is not yet resolved, this adds these annotations back in place using a workaround to prevent the compiler bug from causing issues on ABI stable platforms. This ensures that our public API is the most correct, and in the future when the bug is resolved we can remove the additional AEIC functions that serve as a workaround currently.

@jmschonfeld jmschonfeld requested a review from parkera July 17, 2024 18:24
@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@itingliu itingliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swift-ci please test

@jmschonfeld jmschonfeld merged commit b1716fe into swiftlang:main Jul 18, 2024
@jmschonfeld jmschonfeld deleted the re-add-sendable-annotations branch July 18, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants