rdar://132940984 (Regression: Swift Decoding of Double.greatestFiniteMagnitude as Int causes a crash) #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Magnitude as Int causes a crash)
|
@swift-ci please test |
jmschonfeld
approved these changes
Aug 6, 2024
kperryua
added a commit
to kperryua/swift-foundation
that referenced
this pull request
Aug 6, 2024
…FiniteMagnitude as Int causes a crash) (swiftlang#827) (cherry picked from commit c67f24e)
kperryua
added a commit
to kperryua/swift-foundation
that referenced
this pull request
Aug 6, 2024
…FiniteMagnitude as Int causes a crash) (swiftlang#827) (cherry picked from commit c67f24e)
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
…Magnitude as Int causes a crash) (swiftlang#827)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup from previous change here. Like the previous version of this code, we should immediately throw an error if we fail to decode any Double from the buffer. We'll evaluate if it's expected to be the "wrong" integer only if it succeeds.
The previous fix caused a preconditionFailure crash since we'd fall through to the
validateNumberfunction for a valid syntax JSON number.