Skip to content

do not import stdatomic as it doesn't work with c++ interop on windows #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2024
Merged

do not import stdatomic as it doesn't work with c++ interop on windows #830

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c31fd2c
[windows] do not import stdatomic on windows as it doesn't work with …
hyp Aug 6, 2024
3b76d46
remove the stdatomic include alltogether
hyp Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Sources/_FoundationCShims/include/_CStdlib.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,15 @@
#include <complex.h>
#endif

#if !defined(_WIN32)
// On windows, atomic_signal_fence from clang headers is incompatible
// with atomic_signal_fence definition from MSVC when C++ interop is enabled,
// so drop the stdatomic include.
// Works around: https://github.com/swiftlang/swift/issues/75720
#if __has_include(<stdatomic.h>)
#include <stdatomic.h>
#endif
#endif

#if __has_include(<threads.h>)
#include <threads.h>
Expand Down