Conditionalize stripping of \\?\ on it actually being present
#974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
jrflat
reviewed
Oct 10, 2024
| } else { | ||
| pathBaseAddress = UnsafePointer($0.baseAddress!) | ||
| } | ||
| return try AbsolutePath(String(decodingCString: pathBaseAddress, as: UTF16.self)) |
There was a problem hiding this comment.
error: cannot find 'AbsolutePath' in scope - I think we can probably just return the String(decodingCString:as:) here
There was a problem hiding this comment.
Oh, yes. Copied too much from TSC.
ahoppen
force-pushed
the
conditionalize-windows-path-strip
branch
from
0c683b6 to
79b3148
Compare
|
@swift-ci Please test |
As far as I know `\\?\` is always returned by `GetFinalPathNameByHandleW` but it’s better to be safe and actually check instead of unconditionally trimming the first 4 characters from the returned path. See swiftlang/swift-tools-support-core#485 (comment)
ahoppen
force-pushed
the
conditionalize-windows-path-strip
branch
from
79b3148 to
49981aa
Compare
|
@swift-ci Please test |
|
@swift-ci please test |
jrflat
approved these changes
Oct 11, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
…tlang#974) As far as I know `\\?\` is always returned by `GetFinalPathNameByHandleW` but it’s better to be safe and actually check instead of unconditionally trimming the first 4 characters from the returned path. See swiftlang/swift-tools-support-core#485 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know
\\?\is always returned byGetFinalPathNameByHandleWbut it’s better to be safe and actually check instead of unconditionally trimming the first 4 characters from the returned path.See swiftlang/swift-tools-support-core#485 (comment)