[6.0.2] URL path bug fixes
#983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…strip trailing slashes (swiftlang#867)
Contributor
Author
|
@swift-ci please test |
parkera
approved these changes
Oct 14, 2024
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Oct 17, 2024
We require swiftlang/swift-foundation#983 to be in the toolchain for these test to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes various
URLpath API behaviors to match the expected behavior from before the Swift URL implementation:URL.fileSystemPathandURL.pathURL(filePath:)if a user supplies.notDirectory~paths as absolute inURL(filePath:), resolves the tilde and prevents a crash during initializationScope: Targeted changes to
URLpath APIs to maintain compatibilityOriginal PRs: #852, #867, #961, #964, #965
Risk: Low - Targeted scope, restores expected behavior
Testing: Local, swift-ci from
swift,swift-foundation, andswift-corelibs-foundation, stable inmainReviewers: @jmschonfeld @iCharlesHu