Skip to content

[Traits] Integrate 'disallow disabling default traits of a package without traits' into resolution phase #8356

@bripeticca

Description

@bripeticca

Is it reproducible with SwiftPM command-line tools: swift build, swift test, swift package etc?

  • Confirmed reproduction steps with SwiftPM CLI. The description text must include reproduction steps with either of command-line SwiftPM commands, swift build, swift test, swift package etc.

Description

The PR #8326 has been successfully implemented in the modules graph loading phase, where traits were initially supported. Now that #8205 has been merged, this feature should be considered earlier on in resolution.

Expected behavior

The check for disallowing disabling default traits for a package without traits should be checked during resolution to omit any further calculations/checkouts/etc. if this condition fails.

Actual behavior

This check is being done after resolution has already completed.

Steps to reproduce

No response

Swift Package Manager version/commit hash

No response

Swift & OS version (output of swift --version ; uname -a)

No response

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions