Skip to content

[5.9] Set a default value to the group param for a macro target #6385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

[5.9] Set a default value to the group param for a macro target #6385

merged 1 commit into from
Apr 5, 2023

Conversation

@elsh
Copy link
Contributor

@elsh elsh commented Apr 4, 2023 •
edited
Loading

Set a default value to the group param for a macro target to un-break macro packages per #6365

@elsh elsh requested a review from DougGregor April 4, 2023 22:19
@elsh elsh changed the title Make group param optional [5.9] Make group param optional Apr 4, 2023
@elsh elsh added the swift 5.9 This PR targets the 5.9 branch label Apr 4, 2023
@elsh
Copy link
Contributor Author

elsh commented Apr 4, 2023

@swift-ci smoke test

@elsh elsh mentioned this pull request Apr 4, 2023
Merged
@elsh
Copy link
Contributor Author

elsh commented Apr 4, 2023

main #6384

@elsh elsh changed the title [5.9] Make group param optional [5.9] Make group param optional for a macro target Apr 4, 2023
DougGregor
DougGregor reviewed Apr 4, 2023
View reviewed changes
@elsh elsh changed the title [5.9] Make group param optional for a macro target [5.9] Set a default value to the group param for a macro target Apr 4, 2023
@elsh
Copy link
Contributor Author

elsh commented Apr 4, 2023

@swift-ci smoke test

@elsh elsh enabled auto-merge (squash) April 4, 2023 22:50
@tomerd
Copy link
Contributor

tomerd commented Apr 4, 2023

please merge the one in main first

@elsh
Copy link
Contributor Author

elsh commented Apr 5, 2023

@swift-ci smoke test macOS

@elsh
Copy link
Contributor Author

elsh commented Apr 5, 2023

@swift-ci smoke test windows

@elsh elsh merged commit c41418a into release/5.9 Apr 5, 2023
@elsh elsh deleted the es-rel-opt branch April 5, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DougGregor DougGregor DougGregor approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud abertelrud is a code owner

@neonichu neonichu Awaiting requested review from neonichu neonichu is a code owner

+1 more reviewer

@tomerd tomerd tomerd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

swift 5.9 This PR targets the 5.9 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elsh @tomerd @DougGregor