Package-level moduleAliases should be internal
#6917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were public for implementation reasons, likely because of how the old serialization code worked which I refactored in 5.9 fixes #6911
Contributor
Author
|
@swift-ci please test |
MaxDesiatov
approved these changes
Sep 18, 2023
Contributor
Author
Looks like this was just introduced today by merging swiftlang/swift-format#625? cc @ahoppen |
Member
|
Fixed by swiftlang/swift-format#632 |
Member
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci please test |
neonichu
deleted the
package-level-module-aliases-should-be-internal
branch
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 28, 2023
These were public for implementation reasons, likely because of how the old serialization code worked which I refactored in 5.9 fixes #6911
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 28, 2023
These were public for implementation reasons, likely because of how the old serialization code worked which I refactored in 5.9 fixes #6911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were public for implementation reasons, likely because of how the old serialization code worked which I refactored in 5.9
fixes #6911