[6.0] Deprecate experimental Swift SDK CLI in favor of unprefixed counterparts
#7515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are enough users of this command and corresponding options on `swift build` in the wild. These should be deprecated first before removing.
MaxDesiatov
added
add to change log
enhancement
cross-compilation
swift build
MaxDesiatov
changed the title
experimental Swift SDK CLI if favor of unprefixed counterpartsexperimental Swift SDK CLI if favor of unprefixed counterparts
MaxDesiatov
changed the title
experimental Swift SDK CLI if favor of unprefixed counterpartsexperimental Swift SDK CLI in favor of unprefixed counterparts
Previously these commands weren't covered with end-to-end tests. Now we verify that installation/listing/removal of a fixture Swift SDK succeeds, and also verify that `experimental-sdk` invocations issue a deprecation warning.
|
@swift-ci test |
bnbarham
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #7512 and #7507
Explanation: Since SE-0387 was accepted and available in Swift 5.9 and Swift 5.10, it's time to deprecate relevant CLI with the
experimentalprefix. There are enough users of this command and corresponding options onswift buildin the wild, which means those should be deprecated first before removing.Scope: isolated to
swift sdkcommand and 2 Swift SDK options onswift build.Risk: low, these commands options have no impact on
swift buildoutside of cross-compilation use cases.Testing: added new end-to-end tests in
SDKCommandTestsin #7517 cherry-picked here.Issue: N/A
Reviewer: @bnbarham