Restore visibility of APIs that have been made package
#7568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
MaxDesiatov,
bnbarham,
francescomikulis and
jakepetroules
as code owners
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
xedin
force-pushed
the
revert-visibility-changes
branch
from
e3fdcf2 to
ee0db4b
Compare
|
@swift-ci please test |
bnbarham
approved these changes
May 15, 2024
|
@swift-ci please test Windows platform |
xedin
added a commit
that referenced
this pull request
May 16, 2024
- Explanation: We would still very much like to reduce the visibility of various APIs/modules in SwiftPM to make it easier to make changes/refactor/maintain in general. But given how long these have all been public for, we are reverting these changes for now and instead make posts on the forums asking for feedback for the APIs we'd like to hide. Depending on the API it may be that there's another way to retrieve similar information, or that we need to provide a separate (ideally stable) API for it. - Scope: `package` APIs has been made externally accessible again. - Main Branch PRs: #7568 - Risk: Very Low - Reviewed By: @bnbarham - Testing: Not a functional change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reverts the following PRs and makes it possible to use public and @_spi APIs again.
@_spi#7365packagein the test support module #7372packageaccess control #7381Examples/package-infodirectory as outdated #7434