Include the path to the platform's PrivateFrameworks directory in DYLD_FRAMEWORK_PATH when launching test runners #8199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…D_FRAMEWORK_PATH when launching test runners Resolves rdar://141564191
stmontgomery
requested review from
MaxDesiatov,
bkhouri,
bnbarham,
bripeticca,
dschaefer2,
francescomikulis,
jakepetroules,
owenv,
plemarquand,
shawnhyam and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
|
grynspan
reviewed
Jan 7, 2025
grynspan
approved these changes
Jan 7, 2025
briancroom
approved these changes
Jan 7, 2025
jakepetroules
approved these changes
Jan 8, 2025
stmontgomery
added a commit
that referenced
this pull request
Jan 9, 2025
…in DYLD_FRAMEWORK_PATH when launching test runners (#8204) - **Explanation**: This modifies the logic which sets the value of the `DYLD_FRAMEWORK_PATH` environment variable when launching test runners on Darwin when Xcode is installed: currently it includes the path to the platform's developer "Frameworks" directory, and this change adds the sibling "PrivateFrameworks" directory as well. - **Scope**: Affects tests run on Darwin only, when Xcode is installed. - **Issues**: n/a - **Original PRs**: #8199 - **Risk**: Low. Including this runtime framework search path should have no effect when running tests for any supported version of Xcode. - **Testing**: I validated this works as expected using a local build. - **Reviewers**: @briancroom, @grynspan, @plemarquand, @jakepetroules Resolves rdar://142522110
plemarquand
added a commit
to plemarquand/vscode-swift
that referenced
this pull request
Feb 19, 2025
This is essentially the same change made in: swiftlang/swift-package-manager#8199 VS Code would be able to leverage it for regular runs with `swift test` but because when debugging we launch the xctest executable directly to run tests, we must include the same framework search paths as SPM.
award999
pushed a commit
to swiftlang/vscode-swift
that referenced
this pull request
Feb 20, 2025
This is essentially the same change made in: swiftlang/swift-package-manager#8199 VS Code would be able to leverage it for regular runs with `swift test` but because when debugging we launch the xctest executable directly to run tests, we must include the same framework search paths as SPM.
award999
pushed a commit
to swiftlang/vscode-swift
that referenced
this pull request
Feb 20, 2025
This is essentially the same change made in: swiftlang/swift-package-manager#8199 VS Code would be able to leverage it for regular runs with `swift test` but because when debugging we launch the xctest executable directly to run tests, we must include the same framework search paths as SPM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the logic which sets the value of the
DYLD_FRAMEWORK_PATHenvironment variable when launching test runners on Darwin when Xcode is installed: currently it includes the path to the platform's developer "Frameworks" directory, and this change adds the sibling "PrivateFrameworks" directory as well.Motivation:
XCTest includes some private support frameworks, and these frameworks must be aligned with the public framework for testing to work correctly. This ensures that if the path to the (public) frameworks directory is specified, the aligned private frameworks directory is also included.
Modifications:
$PLATFORM/Developer/Library/PrivateFrameworksto theDYLD_FRAMEWORK_PATHenv var.Resolves rdar://141564191