Fix retain cycle in LLBuildProgressTracker
#8305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
MaxDesiatov,
bkhouri,
bnbarham,
bripeticca,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
shawnhyam and
xedin
as code owners
|
@swift-ci Please test |
MaxDesiatov
approved these changes
Feb 24, 2025
|
@swift-ci Please test |
Kyle-Ye
reviewed
Feb 25, 2025
`self.taskTracker.onTaskProgressUpdateText` captured `self` strongly, creating a reference cycle in `LLBuildProgressTracker`, which caused it to never get deallocated.
ahoppen
force-pushed
the
fix-retain-cycle
branch
from
2ff01ee to
24a86f3
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
plemarquand
approved these changes
Feb 26, 2025
Kyle-Ye
approved these changes
Feb 26, 2025
|
@swift-ci Please test macOS |
ahoppen
added a commit
that referenced
this pull request
Feb 26, 2025
- **Explanation**: `self.taskTracker.onTaskProgressUpdateText` captured `self` strongly, creating a reference cycle in `LLBuildProgressTracker`, which caused it to never get deallocated. - **Scope**: Manifested as a memory leak in SourceKit-LSP - **Issue**: n/a - **Original PR**: #8305 - **Risk**: Low, just captures a delegate weakly - **Testing**: Verified that this fixes the memory leak we saw - **Reviewer**: @MaxDesiatov
jakepetroules
approved these changes
Feb 26, 2025
|
@swift-ci Please test macOS |
bripeticca
pushed a commit
to bripeticca/swift-package-manager
that referenced
this pull request
Feb 28, 2025
`self.taskTracker.onTaskProgressUpdateText` captured `self` strongly, creating a reference cycle in `LLBuildProgressTracker`, which caused it to never get deallocated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.taskTracker.onTaskProgressUpdateTextcapturedselfstrongly, creating a reference cycle inLLBuildProgressTracker, which caused it to never get deallocated.