Skip to content

Conversation

@ahoppen
Copy link
Member

@ahoppen ahoppen commented Mar 7, 2025

This restores the ability to build SwiftPM using a Swift 6.0 compiler.

This restores the ability to build SwiftPM using a Swift 6.0 compiler.
@ahoppen
Copy link
Member Author

ahoppen commented Mar 7, 2025

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge (squash) March 7, 2025 17:41
Copy link
Contributor

@bkhouri bkhouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All CI jobs in Swift PM use the nightly toolchain. As such, I feel SwiftPm should support the nightly toolchain.

Then again, with a lack of a .swift-version, there is nothing in the repository that stipulate the supported Swift toolchain version to build Swift package Manager.

@ahoppen
Copy link
Member Author

ahoppen commented Mar 7, 2025

I think it would be very unfortunate if you couldn’t contribute to SwiftPM (and thus also SourceKit-LSP) with the latest released Swift version, so I think we should make an effort to keep SwiftPM building using the latest released Swift version.

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, this doesn't stop supporting the nightly toolchain, it just allows us to also build with the released toolchain. We should very much keep the ability to do so, it makes it very difficult to contribute to the project otherwise.

@ahoppen ahoppen merged commit 473210b into main Mar 7, 2025
5 checks passed
@ahoppen ahoppen deleted the remove-trailing-comma branch March 7, 2025 23:46
@MaxDesiatov
Copy link
Contributor

Then again, with a lack of a .swift-version, there is nothing in the repository that stipulate the supported Swift toolchain version to build Swift package Manager.

There is, like for any other Swift package it's the tools version stanza on the first line of Package.swift: // swift-tools-version:5.9, which stipulates that SwiftPM should be buildable with Swift 5.9.

@plemarquand
Copy link
Contributor

@MaxDesiatov As of relatively recently swift-package-manager now depends on swift-build, which requires 6.0. I think we should probably update the tools version in Package.swift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants