Add diagnostic for array type #1449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
force-pushed
the
kimdv/add-diagnostic-for-wrong-type
branch
3 times, most recently
from
2870c41 to
f543d98
Compare
kimdv
commented
Mar 27, 2023
ahoppen
approved these changes
Mar 30, 2023
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
LGTM overall, just one comment on where the diagnostic should be anchored.
kimdv
force-pushed
the
kimdv/add-diagnostic-for-wrong-type
branch
4 times, most recently
from
1dc25b3 to
fe4b7f7
Compare
kimdv
force-pushed
the
kimdv/add-diagnostic-for-wrong-type
branch
from
fe4b7f7 to
c87e977
Compare
kimdv
force-pushed
the
kimdv/add-diagnostic-for-wrong-type
branch
2 times, most recently
from
aee0635 to
83d60db
Compare
kimdv
commented
Apr 13, 2023
kimdv
commented
Apr 13, 2023
Contributor
Author
|
@swift-ci please test |
ahoppen
reviewed
Apr 13, 2023
kimdv
force-pushed
the
kimdv/add-diagnostic-for-wrong-type
branch
from
83d60db to
4182d27
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Windows |
kimdv
force-pushed
the
kimdv/add-diagnostic-for-wrong-type
branch
from
4182d27 to
1421a90
Compare
ahoppen
reviewed
Apr 17, 2023
kimdv
force-pushed
the
kimdv/add-diagnostic-for-wrong-type
branch
from
1421a90 to
701f2db
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows |
kimdv
force-pushed
the
kimdv/add-diagnostic-for-wrong-type
branch
from
701f2db to
65eb783
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows |
Contributor
Author
|
@ahoppen can you review this again? |
kimdv
force-pushed
the
kimdv/add-diagnostic-for-wrong-type
branch
from
65eb783 to
7a0068e
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows |
Contributor
Author
|
Waiting for #1558 to be merged |
kimdv
force-pushed
the
kimdv/add-diagnostic-for-wrong-type
branch
from
7a0068e to
0aa8321
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows |
2 similar comments
Contributor
Author
|
@swift-ci please test windows |
Contributor
Author
|
@swift-ci please test windows |
kimdv
added a commit
to kimdv/swift-syntax
that referenced
this pull request
Apr 23, 2023
…-wrong-type Add diagnostic for array type
kimdv
added a commit
to kimdv/swift-syntax
that referenced
this pull request
May 22, 2023
…-wrong-type Add diagnostic for array type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.