Add diagnostic if #endif is followed by any declarations
#1833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
commented
Jun 22, 2023
ahoppen
reviewed
Jun 22, 2023
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Could you do the same for #sourceLocation?
kimdv
force-pushed
the
kimdv/fix-diagnostic-for-declarations-after-endif
branch
2 times, most recently
from
02619a7 to
1dc643c
Compare
kimdv
force-pushed
the
kimdv/fix-diagnostic-for-declarations-after-endif
branch
2 times, most recently
from
3359a6c to
c5684e0
Compare
ahoppen
reviewed
Jul 6, 2023
kimdv
force-pushed
the
kimdv/fix-diagnostic-for-declarations-after-endif
branch
from
c5684e0 to
8b3428f
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows |
ahoppen
reviewed
Jul 8, 2023
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Oh, and one thing that just crossed my mind: Could you also add test cases for statements on the same line as #if, #elseif and #else?
kimdv
force-pushed
the
kimdv/fix-diagnostic-for-declarations-after-endif
branch
from
8b3428f to
74dc3f8
Compare
kimdv
commented
Jul 8, 2023
Contributor
Author
Good catch! |
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1823