Skip to content

[6.0] Mark MultithreadingTests as @unchecked Sendable to work around rdar://130094927 #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2024
Merged

[6.0] Mark MultithreadingTests as @unchecked Sendable to work around rdar://130094927 #2746

merged 2 commits into from
Jul 23, 2024

Conversation

@ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 19, 2024

  • Explanation: swift-syntax did not build without warnings on Linux due to rdar://130094927. Building without warnings is a requirement for us to release a new swift-syntax version, so work around that warning by adding @unchecke Sendable.
  • Scope: Test-only change
  • Risk: Low, test-only change
  • Testing: Checked that swift-syntax builds without warnings on Linux with this change
  • Issue: n/a
  • Reviewer: @bnbarham

@ahoppen ahoppen requested a review from bnbarham as a code owner July 19, 2024 17:33
@ahoppen
Copy link
Member Author

ahoppen commented Jul 19, 2024

@swift-ci Please test

@ahoppen ahoppen changed the title Mark MultithreadingTests as @unchecked Sendable to work around rdar://130094927 [6.0] Mark MultithreadingTests as @unchecked Sendable to work around rdar://130094927 Jul 19, 2024
@ahoppen ahoppen enabled auto-merge July 19, 2024 17:45
@grynspan
Copy link
Contributor

grynspan commented Jul 22, 2024

This is something we probably need to fix on the XCTest side, no?

@ahoppen
Copy link
Member Author

ahoppen commented Jul 22, 2024

This is something we probably need to fix on the XCTest side, no?

Yes, that would be good.

@ahoppen ahoppen force-pushed the 6.0/multithreadingtest-sendable branch from 750f5c3 to f9e1e8d Compare July 22, 2024 20:51
@ahoppen
Copy link
Member Author

ahoppen commented Jul 22, 2024

@swift-ci Please test

1 similar comment
@ahoppen
Copy link
Member Author

ahoppen commented Jul 22, 2024

@swift-ci Please test

@ahoppen ahoppen force-pushed the 6.0/multithreadingtest-sendable branch from f9e1e8d to ee2b821 Compare July 23, 2024 00:43
@ahoppen
Copy link
Member Author

ahoppen commented Jul 23, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jul 23, 2024

@swift-ci Please test Windows

@rintaro @ahoppen
[MacroExamples] Update invalid URL example
4c3a198 
Workaround for a Foundation bug that can return non-nil URL for
"https://not a url.com".
@ahoppen
Copy link
Member Author

ahoppen commented Jul 23, 2024

@swift-ci Please test

1 similar comment
@ahoppen
Copy link
Member Author

ahoppen commented Jul 23, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit 19ff4a1 into swiftlang:release/6.0 Jul 23, 2024
@ahoppen ahoppen mentioned this pull request Jul 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahoppen @grynspan @bnbarham @rintaro