Continue encoding value for deprecated property in runner plan snapshot to avoid decoding error in clients #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot to avoid decoding error in clients Fixes rdar://146284519
stmontgomery
added
bug
stmontgomery
requested review from
SeanROlszewski,
briancroom,
grynspan and
suzannaratcliff
as code owners
|
@swift-ci please test |
briancroom
approved these changes
Mar 13, 2025
grynspan
reviewed
Mar 13, 2025
grynspan
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression in the encoding of the
Runner.Plansnapshot types, which can manifest when using Xcode 16.Motivation:
The
isParallelizationEnabledproperty was deprecated and changed from a stored property to a derived one in #901. That caused the value to no longer be encoded inRunner.Plan.Action.RunOptions, which can cause decoding errors in versions of Xcode which expect it to still be present.Modifications:
Codableconformance for the affected type to begin including a hardcoded value.Checklist:
Fixes rdar://146284519