Skip to content

Tweaks to some feature conditionals. #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2023
Merged

Tweaks to some feature conditionals. #129

merged 1 commit into from
Nov 20, 2023

Conversation

@grynspan
Copy link
Contributor

@grynspan grynspan commented Nov 20, 2023 •
edited
Loading

This PR replaces SWT_NO_TAG_COLORS with SWT_NO_FILE_IO and applies that conditional elsewhere in the package where we perform file I/O. It also fixes !SWT_NO_UTC_CLOCK gating availability of Test.Clock.Instant.nanoseconds(until:), which was not intentional.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Tweaks to some feature conditionals.
e8b3477 
This PR replaces `SWT_NO_TAG_COLORS` with `SWT_NO_FILE_IO` and applies that conditional elsewhere in the package where we perform file I/O. It also fixes `!SWT_NO_UTC_CLOCK` gating availability of `Test.Clock.Instant.nanoseconds(until:)`, which was not intentional.
@grynspan grynspan self-assigned this Nov 20, 2023
@grynspan grynspan added the bug 🪲 Something isn't working label Nov 20, 2023
@grynspan grynspan marked this pull request as ready for review November 20, 2023 18:53
@grynspan
Copy link
Contributor Author

grynspan commented Nov 20, 2023

@swift-ci please test

@grynspan
Copy link
Contributor Author

grynspan commented Nov 20, 2023

Reviewed internally on the team.

@grynspan grynspan merged commit 39585df into main Nov 20, 2023
@grynspan grynspan deleted the jgrynspan/refine-feature-conditions branch November 20, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff

@ejvaughan ejvaughan Awaiting requested review from ejvaughan

Assignees

@grynspan grynspan

Labels

bug 🪲 Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grynspan