Make FileSystem and conforming types as Sendable
#402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
MaxDesiatov
changed the title
FileSystem and confirming types as SendableFileSystem and conforming types as Sendable
MaxDesiatov
force-pushed
the
maxd/sendable-filesystem
branch
from
4d14e6c to
e65e182
Compare
|
@swift-ci test |
neonichu
approved these changes
Mar 20, 2023
|
@swift-ci test macos |
|
@swift-ci test macos |
1 similar comment
|
@swift-ci test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types that conform to
FileSystemeither don't have in-memory state to be protected with locks at all and use blocking I/O under the hood (likeLocalFileSystem), or already protect their state with locks, likeInMemoryFileSystem. Few other types in SwiftPM conforming toFileSystemeither also use locks (likeGitFileSystemView) or are read-only (likeVirtualFileSystem). I'm convinced that adding aSendablerequirement onFileSystemis beneficial overall, since it's already passed around between Dispatch queues and other concurrent code that would allow us to resolve sendability warnings.