Remove redundant addclose calls #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't need to use addclose on the file descriptors we're closing ourselves explicitly.
neonichu
requested review from
MaxDesiatov,
abertelrud and
tomerd
as code owners
|
@swift-ci please test |
MaxDesiatov
approved these changes
Nov 6, 2023
grynspan
approved these changes
Nov 6, 2023
grynspan
approved these changes
Nov 6, 2023
|
I see it now |
|
@swift-ci please test windows |
|
This should fix the windows test issue - swiftlang/swift#69689 |
|
Merged to unblock CI bots |
grynspan
added a commit
that referenced
this pull request
Nov 7, 2023
tomerd
pushed a commit
that referenced
this pull request
Nov 8, 2023
grynspan
pushed a commit
that referenced
this pull request
Nov 9, 2023
We shouldn't need to use addclose on the file descriptors we're closing ourselves explicitly.
grynspan
added a commit
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't need to use addclose on the file descriptors we're closing ourselves explicitly.