Skip to content

Conversation

jeffdav
Copy link
Contributor

@jeffdav jeffdav commented Apr 24, 2024

We must call the API with nil first to get the size of the buffer, then allocate that amount.

This fixes a crash in swift-driver on Windows.

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself seems fine, though I'm not too big a fan of the whitespace changes.

@compnerd
Copy link
Member

@swift-ci please test

@compnerd compnerd enabled auto-merge (rebase) April 26, 2024 15:24
@compnerd compnerd disabled auto-merge April 26, 2024 15:24
@compnerd compnerd enabled auto-merge (squash) April 26, 2024 15:24
@compnerd compnerd merged commit b170d46 into swiftlang:main Apr 26, 2024
@jeffdav jeffdav deleted the jeff/fix-windows-path-api-usage branch April 26, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants