Skip to content

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 16, 2024

@ahoppen
Copy link
Member Author

ahoppen commented Oct 16, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Oct 16, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Oct 16, 2024

@swift-ci Please test Windows

@ahoppen
Copy link
Member Author

ahoppen commented Oct 16, 2024

macOS failure is the same as #485 (comment)

macOS CI failure is unrelated. This change only affects Windows. macOS CI is failing because this is the only repo that build SourceKit-LSP using a 5.9 host compiler, but SourceKit-LSP requires 5.10 to build successfully. We didn’t hit this before because this repo hasn’t seen any changes in the last 2 months, which is when SourceKit-LSP started requiring Swift 5.10.

@ahoppen
Copy link
Member Author

ahoppen commented Oct 16, 2024

@swift-ci Please test Windows

@shahmishal shahmishal merged commit ad2fc22 into swiftlang:main Oct 17, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants