[6.1] Fix the Android build #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bnbarham, need a CI run here. |
|
@swift-ci test |
bnbarham
approved these changes
Dec 4, 2024
Sorry, I've been off and only catching up now. But looks like you can now run now 🥳! |
|
@swift-ci test windows |
|
@shahmishal, does something need to be setup to get the 6.1 branch of this repo tested on Windows, because my above attempts so far don't appear to do anything? |
|
Please try again, I just fixed the issue with Windows trigger. |
|
@swift-ci test windows |
|
Yep, kicked off again. 👍 Thanks, Mishal, will let you know if I see any other problems. |
Jaewchn
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This import was missed and the Android cross-compile complains.
Scope: A single import for C functions
Issue: None
Original PRs: #492
Risk: Practically non-existent
Testing: Passed all CI on trunk
Reviewer: @owenv
This pull from @jakepetroules was merged right after the 6.1 branch: I don't want to have to apply it for the 6.1 builds on my Android CI for the next year.