Skip to content

Revert "Use C to force the POSIX (not GNU) overload of strerror_r to be selected" #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

Revert "Use C to force the POSIX (not GNU) overload of strerror_r to be selected" #498

merged 1 commit into from
Mar 4, 2025

Conversation

@rintaro
Copy link
Member

@rintaro rintaro commented Mar 4, 2025 •
edited
Loading

Reverts #497

Possibly causing a linker failure.
https://ci.swift.org/job/oss-swift-package-amazon-linux-2/4036/console

error: link command failed with exit code 1 (use -v to see invocation)
/usr/bin/ld.gold: error: lib/libTSCclibc.a(strerror.c.o): requires dynamic R_X86_64_PC32 reloc against '__xpg_strerror_r' which may overflow at runtime; recompile with -fPIC
clang-13: error: linker command failed with exit code 1 (use -v to see invocation)
error: fatalError

rdar://145919939

@rintaro
Copy link
Member Author

rintaro commented Mar 4, 2025

@swift-ci Please test

@rintaro rintaro merged commit 0cd155c into main Mar 4, 2025
0 of 3 checks passed
@rintaro rintaro deleted the revert-497-android branch March 4, 2025 01:16
@marcprux marcprux mentioned this pull request Mar 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnbarham bnbarham Awaiting requested review from bnbarham

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rintaro