Bring back "Use C to force the POSIX (not GNU) overload of strerror_r to be selected" #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows building TSC for Android without needing to pass custom flags via -Xcc.
…ng to build on Amazon Linux 2 otherwise
|
@swift-ci test |
|
@jakepetroules, this now built fine on the Amazon Linux 2 CI after I added the commit with a single CMake tweak (that CI is currently broken because it doesn't pass the SwiftPM tests, but this pull now maintains that status quo). Please review. |
|
Thank you; I hadn't gotten a chance to come back to this earlier! |
jakepetroules
approved these changes
Mar 19, 2025
This was referenced Apr 1, 2025
finagolfin
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Apr 2, 2025
…p dlerror() (#8438) Removing the definition of `_GNU_SOURCE` is no longer needed since swiftlang/swift-tools-support-core#500 made sure the right `strerror_r()` is used, and `dlerror()` has to be unwrapped because of its `_Nullable` annotation.
finagolfin
added a commit
to swiftlang/swift-driver
that referenced
this pull request
Apr 2, 2025
Removing the definition of `_GNU_SOURCE` is no longer needed since swiftlang/swift-tools-support-core#500 made sure the right `strerror_r()` is used.
bnbarham
pushed a commit
to swiftlang/sourcekit-lsp
that referenced
this pull request
Apr 3, 2025
Removing the definition of `_GNU_SOURCE` is no longer needed since swiftlang/swift-tools-support-core#500 made sure the right `strerror_r()` is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows building TSC for Android without needing to pass custom flags via -Xcc.
Let's see what failed on Amazon linux last time.