Error type cleanup #18392
Merged
Error type cleanup #18392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reference storage qualifiers Also, remove AbstractStorageDecl::getStorageInterfaceType(), which was almost identical.
We would bail out early if the function type contained an error type anywhere, which is incorrect.
…against ill-formed code In an upcoming patch we're going to start calling computeType() on constructors and destructors parsed outside type context, so let's just bail out if we're not in type context, instead of crashing.
…Params() to typeCheckDecl() Checking these in a code path called from validateDecl() is overkill; it's sufficient to perform these checks in declarations in primary files only.
Contributor
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dusting off a few cleanups I've had sitting around for a while.