Skip to content

AST: Fix computeSelfParam() to respect __consuming on class methods #29579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2020
Merged

AST: Fix computeSelfParam() to respect __consuming on class methods #29579

merged 2 commits into from
Feb 1, 2020

Conversation

@slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Jan 31, 2020

Fixes rdar://problem/58887618.

@slavapestov slavapestov requested a review from CodaFi January 31, 2020 23:30
@slavapestov
Copy link
Contributor Author

slavapestov commented Jan 31, 2020

@swift-ci Please test source compatibility

@BasThomas BasThomas mentioned this pull request Feb 1, 2020
Closed
@slavapestov slavapestov force-pushed the no-ethical-consumption-of-class-methods branch from 07081b5 to 62ca2aa Compare February 1, 2020 00:37
@slavapestov slavapestov merged commit 7cabef8 into swiftlang:master Feb 1, 2020
@davezarzycki davezarzycki mentioned this pull request Feb 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CodaFi CodaFi CodaFi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slavapestov @CodaFi