[CSBindings] NFC: Simplify TypeVariableBinding::attempt but extract…
#34105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing fix computation Add a separate method `fixForHole` on `TypeVariableBinding` responsible for determining whether fix is required and if so, what kind of fix to apply when a particular type variable is resolved to a hole.
xedin
force-pushed
the
refactor-typevar-binding-attempt
branch
from
0fd9ba6 to
225d87a
Compare
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing fix computation
Add a separate method
fixForHoleonTypeVariableBindingresponsible for determining whether fix is required and if so,
what kind of fix to apply when a particular type variable is
resolved to a hole.