[Serialization] Add an option to output modules regardless of errors #34472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
bnbarham
force-pushed
the
benb/allow-errors-69815975
branch
from
54e0661 to
0ffb7e9
Compare
|
@swift-ci please test |
xymus
approved these changes
Oct 29, 2020
I'm hoping there's shouldn't be many more errors to suppress, but I suspect there likely is. |
bnbarham
force-pushed
the
benb/allow-errors-69815975
branch
from
c64c163 to
f5f87a5
Compare
bnbarham
changed the title
|
Going to merge and fix any error that crop up from the stress tester after the fact (this arg will only be used in an opt-in mode for now). |
|
@swift-ci please smoke test |
bnbarham
force-pushed
the
benb/allow-errors-69815975
branch
from
f5f87a5 to
ef0e4d7
Compare
|
@swift-ci please smoke test |
Adds a new frontend option "-experimental-allow-module-with-compiler-errors". If any compilation errors occur while generating the .swiftmodule, this mode will skip SIL entirely and only serialize the (likey invalid) AST. This existence of this option during generation is serialized into the resulting .swiftmodule. Errors found in deserialization are only allowed if it is set. Primarily intended for IDE requests (eg. indexing and code completion) to ensure robust cross-module results, despite possible errors. Resolves rdar://69815975
bnbarham
force-pushed
the
benb/allow-errors-69815975
branch
from
ef0e4d7 to
241559d
Compare
|
Fixed test after a couple other PRs were merged to fix the missing global case. @swift-ci please smoke test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new frontend option
"-experimental-allow-module-with-compiler-errors". If any compilation
errors occur while generating the .swiftmodule, this mode will skip SIL
entirely and only serialize the (likey invalid) AST.
This existence of this option during generation is serialized into the
resulting .swiftmodule. Errors found in deserialization are only allowed
if it is set.
Primarily intended for IDE requests (eg. indexing and code completion)
to ensure robust cross-module results, despite possible errors.
Resolves rdar://69815975