[Dependency Scanner] Share ModuleDependenciesCache as a part of the CompilerInstance
#34646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
… CompilerInstance This will allow individual module scans in batch-scanning mode to share the already-scanned Swift and Clang modules, and avoid instantiating a brand new Clang `DependencyScanningService` for each batch entry. Performance-improvement anecdote: A simple experiment which performs a batch scan of all modules involved in planning a build of SwiftPM (using SwiftPM in explicit module build mode), which includes 126 batch entries (scan entry-points), with 21 distinct Swift modules and 27 distinct Clang modules (many Clang modules are scanned multiple times, at different target versions), this modification reduces the total time taken from ~34 seconds to ~6.
artemcm
force-pushed
the
BatchScanShouldShareCache
branch
from
b1054a5 to
10b6b9d
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Windows platform |
1 similar comment
Contributor
Author
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow individual module scans in batch-scanning mode to share the already-scanned Swift and Clang module dependencies, and avoid instantiating a new Clang
DependencyScanningServicefor each batch entry.Performance-improvement anecdote:
A simple experiment was carried out which performs a batch scan of all modules involved in planning a build of SwiftPM. The input batch includes 126 entries (scan entry-points), with 21 distinct Swift modules and 27 distinct Clang modules (many Clang modules are scanned multiple times, at different target versions). For this experiment, this modification reduces the total time taken from ~34 seconds to ~6.