[ownership] Convert ValueOwnershipKind to have an Invalid state instead of using optional. #34659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of using optional. At Andy's request. If it creates too much noise in covered switches, we may go back to the original.
Contributor
Author
|
@swift-ci smoke test |
atrick
approved these changes
Nov 10, 2020
Contributor
atrick
left a comment
atrick
left a comment
There was a problem hiding this comment.
Please get rid of the special-casing for Invalid. Otherwise this looks great.
Optional is appropriate when a particular API may fail. But here "Invalid" is actually an expected state, and normal state for constraints. It just means "any" or "unknown" ownership which happens to be invalid when applied to values because we have strict ownership rules for values.
| // If either lhs or rhs are invalid, return invalid. | ||
| if (lhsVal == ValueOwnershipKind::Invalid || | ||
| rhsVal == ValueOwnershipKind::Invalid) | ||
| return ValueOwnershipKind::Invalid; |
Contributor
There was a problem hiding this comment.
You shouldn't be special-casing invalid here.
Contributor
Author
|
Going to fix Andys comments in a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Andy's request. If it creates too much noise in covered switches, we may go
back to the original.