Fix issues with discontiguous-slice assignment #34708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mutating collection subscript for discontiguous slices assigns to the wrong group of indices. This fixes the behavior and adds test coverage. rdar://problem/70690643
|
@swift-ci Please smoke test |
lorentey
approved these changes
Nov 15, 2020
|
Per conversations before the initial adoption, yes, but it's probably worth verifying that's a good idea. Thanks! |
ainu-bot
added a commit
to google/swift
that referenced
this pull request
Nov 18, 2020
* 'main' of github.com:apple/swift: Remove old swift_dynamicCast implementation (swiftlang#34789) Fix issues with discontiguous-slice assignment (swiftlang#34708) [Concurrency] Emit @asyncHandler bodies as traps. [Clang importer] Narrow mirrored-import fixes to only consider 'async'. [Clang importer] Make sure we mirror protocol decls for all names. [sil] Element shadowing of SILInstruction::getKind() by renaming MarkUninitializedInst::get{,MarkUninitialized}Kind(). XFAIL Flaky Incremental Tests Harder [allocbox-to-stack] Eliminate temporary dominance issue and fix improper use of non-ossa generic method createDestroyValue. [Serialization] Fix crashes when allowing compiler errors in modules [windows] Set TMP and TEMP, as well as TMPDIR. [android] Mark Interpreter/async as an executable test. IRGen: Allow calling a pre-defined async silgen_name function using the async convention Demangling: avoid implicit fallthrough [Runtime] Change ProtocolCache, NominalCache, and HashableConformances to ConcurrentReadableHashMap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mutating collection subscript for discontiguous slices assigns to the wrong group of indices. This fixes the behavior and adds test coverage.
rdar://problem/70690643