Skip to content

Conversation

asl
Copy link
Contributor

@asl asl commented Jul 20, 2022

Pull request #58965 fixed a number of other issues including debug info verification error in #59467. It turned that in the latter the types were queried in the wrong module as typechecking occurred too late.

Resolves #59467

@asl
Copy link
Contributor Author

asl commented Jul 20, 2022

@swift-ci please test

@asl
Copy link
Contributor Author

asl commented Jul 20, 2022

Tagging @philipturner @BradLarson

@asl asl requested review from dan-zheng and rxwei July 20, 2022 17:55
Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good!

@philipturner
Copy link
Contributor

@asl Thanks!

@asl asl merged commit 8fa3d2f into main Jul 20, 2022
@asl asl deleted the 59467-fix branch July 20, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AutoDiff][IRGen] Can't compile Swift for TensorFlow on top-of-tree Swift

3 participants