Embedded: enable *-unknown-windows-coff triples in Platform.cpp
#72217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the frontend to proceed when building with `-target i686-unknown-windows-coff -enable-experimental-feature Embedded` arguments.
MaxDesiatov
added
Windows
Contributor
Author
|
@swift-ci smoke test |
MaxDesiatov
added
the
needs tests
compnerd
approved these changes
Mar 10, 2024
Contributor
|
What does it mean to have no environment on Windows? (See also swiftlang/swift-driver#1558.) |
Contributor
Author
IIUC it means that no assumptions about current environment are made and MSVC toolchain is not required. One could use MinGW infrastructure or something else to build for this triple. |
Contributor
Author
|
@swift-ci test macos |
Contributor
Let's discuss that on the other PR. I have no objection to supporting the |
al45tair
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the frontend to proceed when building with
-target i686-unknown-windows-coff -enable-experimental-feature Embeddedarguments.