Skip to content

[WIP] Add swift-foundation to toolchain build #73403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[WIP] Add swift-foundation to toolchain build #73403

wants to merge 7 commits into from

Conversation

@jmschonfeld
Copy link
Contributor

This is a WIP PR to add the swift-foundation set of projects to the toolchain build for use by swift-corelibs-foundation

@jmschonfeld
Copy link
Contributor Author

swiftlang/swift-foundation-icu#22

@swift-ci please build toolchain linux platform

3 similar comments
@jmschonfeld
Copy link
Contributor Author

swiftlang/swift-foundation-icu#22

@swift-ci please build toolchain linux platform

@iCharlesHu
Copy link
Contributor

swiftlang/swift-foundation-icu#22

@swift-ci please build toolchain linux platform

@jmschonfeld
Copy link
Contributor Author

swiftlang/swift-foundation-icu#22

@swift-ci please build toolchain linux platform

edymtt
edymtt reviewed May 3, 2024
View reviewed changes
utils/swift_build_support/swift_build_support/build_script_invocation.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to avoid creating a new pipeline and piggyback instead on the first one -- effectively moving this line after the addition of the LibCurl product

utils/swift_build_support/swift_build_support/products/foundation.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be best to have a separate python file for this class (e.g. foundation_icu.py)

@jmschonfeld
Copy link
Contributor Author

swiftlang/swift-corelibs-foundation#4948
swiftlang/swift-foundation-icu#22

@swift-ci please build toolchain linux platform

1 similar comment
@iCharlesHu
Copy link
Contributor

swiftlang/swift-corelibs-foundation#4948
swiftlang/swift-foundation-icu#22

@swift-ci please build toolchain linux platform

@jmschonfeld
Copy link
Contributor Author

https://github.com/apple/swift-corelibs-foundation/pull/4948/files
swiftlang/swift-foundation-icu#22

@swift-ci please build toolchain linux platform

@jmschonfeld
Copy link
Contributor Author

swiftlang/swift-corelibs-foundation#4948
swiftlang/swift-foundation-icu#22

@swift-ci please build toolchain linux platform

@jmschonfeld jmschonfeld force-pushed the swift-foundation-toolchain branch from 2d28001 to 27fbd5a Compare May 20, 2024 21:32
@jmschonfeld
Copy link
Contributor Author

swiftlang/swift-foundation-icu#22
swiftlang/swift-foundation#573
swiftlang/swift-corelibs-foundation#4959

@swift-ci please build toolchain linux platform

2 similar comments
@jmschonfeld
Copy link
Contributor Author

swiftlang/swift-foundation-icu#22
swiftlang/swift-foundation#573
swiftlang/swift-corelibs-foundation#4959

@swift-ci please build toolchain linux platform

@jmschonfeld
Copy link
Contributor Author

swiftlang/swift-foundation-icu#22
swiftlang/swift-foundation#573
swiftlang/swift-corelibs-foundation#4959

@swift-ci please build toolchain linux platform

@jmschonfeld
Copy link
Contributor Author

apple/swift-collections#377
swiftlang/swift-foundation-icu#22
swiftlang/swift-foundation#573
swiftlang/swift-corelibs-foundation#4959

@swift-ci please build toolchain linux platform

@jmschonfeld
Copy link
Contributor Author

apple/swift-collections#378
swiftlang/swift-foundation-icu#22
swiftlang/swift-foundation#573
swiftlang/swift-corelibs-foundation#4959

@swift-ci please build toolchain linux platform

3 similar comments
@jmschonfeld
Copy link
Contributor Author

apple/swift-collections#378
swiftlang/swift-foundation-icu#22
swiftlang/swift-foundation#573
swiftlang/swift-corelibs-foundation#4959

@swift-ci please build toolchain linux platform

@jmschonfeld
Copy link
Contributor Author

apple/swift-collections#378
swiftlang/swift-foundation-icu#22
swiftlang/swift-foundation#573
swiftlang/swift-corelibs-foundation#4959

@swift-ci please build toolchain linux platform

@jmschonfeld
Copy link
Contributor Author

apple/swift-collections#378
swiftlang/swift-foundation-icu#22
swiftlang/swift-foundation#573
swiftlang/swift-corelibs-foundation#4959

@swift-ci please build toolchain linux platform

@iCharlesHu
Copy link
Contributor

apple/swift-collections#379
swiftlang/swift-foundation-icu#22
swiftlang/swift-foundation#573
swiftlang/swift-corelibs-foundation#4959

@swift-ci please build toolchain linux platform

@iCharlesHu
Copy link
Contributor

apple/swift-collections#379
swiftlang/swift-foundation-icu#22
swiftlang/swift-foundation#573
swiftlang/swift-corelibs-foundation#4959

@swift-ci please clean build toolchain linux platform

2 similar comments
@jmschonfeld
Copy link
Contributor Author

apple/swift-collections#379
swiftlang/swift-foundation-icu#22
swiftlang/swift-foundation#573
swiftlang/swift-corelibs-foundation#4959

@swift-ci please clean build toolchain linux platform

@jmschonfeld
Copy link
Contributor Author

apple/swift-collections#379
swiftlang/swift-foundation-icu#22
swiftlang/swift-foundation#573
swiftlang/swift-corelibs-foundation#4959

@swift-ci please clean build toolchain linux platform

@jmschonfeld jmschonfeld force-pushed the swift-foundation-toolchain branch from 50239d7 to 4e9d6d9 Compare May 24, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edymtt edymtt edymtt left review comments

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal will be requested when the pull request is marked ready for review shahmishal is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmschonfeld @iCharlesHu @edymtt