[ConstraintSystem] Downgrade some invalid specialization uses to a warning until Swift 6 language mode #76141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rning until Swift 6 language mode Some invalid specializations were previously allowed by the compiler and we found some existing code that used that (albeit invalid) syntax, so we need to stage that error as a warning until Swift 6 language mode to avoid source compatibility break. Resolves: rdar://134740240
Instead of "a generic function" which is too abstract and not always correct, let's actually point to a kind of the declaration being referenced.
xedin
requested review from
CodaFi,
DougGregor,
ahoppen,
bnbarham,
hamishknight,
hborla,
rintaro and
slavapestov
as code owners
Contributor
Author
|
@swift-ci please test |
hamishknight
approved these changes
Aug 29, 2024
hborla
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some invalid specializations were previously allowed by the compiler
and we found some existing code that used that (albeit invalid) syntax,
so we need to stage that error as a warning until Swift 6 language mode
to avoid source compatibility break.
Resolves: rdar://134740240