[Test] Make timeout.py signal an error when the timeout is hit. #76146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Print an error message and exit with a non-zero code when we hit the timeout. This makes it clear when a test fails due to a timeout. On Darwin, run `sample` on the target process first, so that the failure includes some information about what the test was doing when the timeout occurred.
…400 seconds while we investigate timeouts in CI.
mikeash
force-pushed
the
test-timeout-error-message-2
branch
from
4500e88 to
eead3fa
Compare
Contributor
Author
|
@swift-ci please test |
eeckstein
added a commit
to eeckstein/swift
that referenced
this pull request
Sep 3, 2024
…b again It turns out that some CI jobs need 5-6 minutes for this test. To give some slack, use a timeout of 10 minutes. This is a follow-up of swiftlang#76146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print an error message and exit with a non-zero code when we hit the timeout. This makes it clear when a test fails due to a timeout. On Darwin, run
sampleon the target process first, so that the failure includes some information about what the test was doing when the timeout occurred.This also temporarily increases the timeout for the
large_nested_array.swift.gybtest, which hits this new louder timeout in CI, while we investigate.