[6.1][Parser] Include all AST nodes from every #if region in ParserUnit #79123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
bnbarham
approved these changes
Feb 3, 2025
rintaro
force-pushed
the
6.1-parser-unit-ifconfig-allactive-rdar117387631
branch
from
79b95ce to
f63e52b
Compare
Member
Author
|
@swift-ci Please test |
'ParserUnit' is used for analyzing syntax structures _mainly_ in SourceKit. Since we removed IfConfigDecl from AST, ParserUnit didn't inclue any AST in #if ... #endif regions even for active region because it used to consider all inactive. Instead, consider every region "active" and include all the AST nodes. rdar://117387631 (cherry picked from commit 694e815)
rintaro
force-pushed
the
6.1-parser-unit-ifconfig-allactive-rdar117387631
branch
from
f63e52b to
3af9ba8
Compare
Member
Author
|
@swift-ci Please test |
1 similar comment
Member
Author
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #79120 into
release/6.1ParserUnitis used for analyzing syntax structures mainly in SourceKit. Since we removedIfConfigDeclfrom AST,ParserUnitdidn't include any AST in#if ... #endifregions even for active region because it used to consider all inactive. Instead, consider every region "active" and include all the AST nodes.ParserUnitwhich is used in SourceKit (for syntactic analysis),-define-availabilityargument parsing (never accept#if), and inlldbfor checking if the statement is incomplete or not.IfConfigDeclremoval.