TempRValueElimination: re-implement the pass in swift #81286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
requested review from
atrick,
meg-gupta and
nate-chandler
and removed request for
jckarter
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci apple silicon benchmark |
atrick
reviewed
May 5, 2025
It's based on `InstructionSet` but also provides a `count` property
…tionOfDest` -> `isInitializationOfDestination` Trying to avoid abbreviations in ABI names
* `OpenExistentialAddrInst.isImmutable` * `YieldInst.convention` * `CopyAddrInst.set(isTakeOfSource:)` and `CopyAddrInst.set(isInitializationOfDestination:)`
Beside cleaning up the source code, the motivation for the translation into Swift is to make it easier to improve the pass for some InlineArray specific optimizations (though I'm not sure, yet if we really need those). Also, the new implementation doesn't contain the optimize-store-into-temp optimization anymore, because this is covered by redundant load elimination.
Contributor
Author
|
@swift-ci smoke test |
atrick
approved these changes
May 6, 2025
Contributor
atrick
left a comment
atrick
left a comment
There was a problem hiding this comment.
Basically looks good. But I really wish things like UseCollector were using AddressUseVisitor instead of AddressDefUseWalker. Otherwise I can't reason about correctness and it could easily break as SIL evolves. The operations that AddressDefUseWalker follows or calls "leaf" are arbitrary, so the default implementation is tightly coupled with all the conformances. It will be important for passes like this to handle mark_dependence and mark_dependence_addr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beside cleaning up the source code, the motivation for the translation into Swift is to make it easier to improve the pass for some InlineArray specific optimizations (though I'm not sure, yet if we really need those).
Also, the new implementation doesn't contain the optimize-store-into-temp optimization anymore, because this is covered by redundant load elimination.