[Modules] Allow implicit conversions when loading interfaces with invalid os versions #82228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyndyishida
requested review from
DougGregor,
Xazax-hun,
artemcm,
beccadax,
egorzhdan,
fahadnayyar,
hborla,
ian-twilightcoder,
j-hui,
slavapestov,
susmonteiro,
xedin and
zoecarver
as code owners
|
@swift-ci please test |
cyndyishida
commented
Jun 12, 2025
tshortli
approved these changes
Jun 12, 2025
|
Thank you Cyndy! |
nkcsgexi
approved these changes
Jun 12, 2025
cyndyishida
force-pushed
the
eng/PR-OneVersionForThemAll
branch
from
e28a656 to
5045f7b
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test |
…alid os versions. Initially, the compiler rejected building dependencies that contained OS versions in an invalid range. This happens to be quite disruptive, so instead allow it and request that these versions be implicitly bumped based on what `llvm::getCanonicalVersionForOS` computes
cyndyishida
force-pushed
the
eng/PR-OneVersionForThemAll
branch
from
5045f7b to
977a1e1
Compare
|
@swift-ci please smoke test |
|
swiftlang/swift-driver#1931 |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, the compiler rejected building dependencies that contained OS versions in an invalid range. However, this happens to be quite disruptive, so instead allow it and request that these versions be implicitly bumped based on what
llvm::Triple::getCanonicalVersionForOScomputes.resolves: rdar://153205856