[windows] add a parameter to pick which Windows SDK version to build #83455
Conversation
|
@swift-ci please test |
utils/build.ps1
Outdated
| If set, skips building the msi's and installer | ||
| If set, skips building the msi's and installer. | ||
| .PARAMETER SkipExperimentalSDK |
There was a problem hiding this comment.
I don't think that this should be another parameter. Perhaps we can handle this uniformly with -SDK; this does however make testing harder.
There was a problem hiding this comment.
Thinking a bit about this - it would actually be helpful to have this functionality more generically: we should be able to disable the non-experimental SDK bits more than the experimental SDK bits. The experimental SDK is what will become the default. That would also help with testing; perhaps we can have something clever as the specifier in the -WindowsSDKs and -AndroidSDKs to control which SDK and architectures we support. I would be open to renaming the options btw, they currently control the architectures in the SDK, not the SDKs. If we can simplify the logic for the handling, perhaps something like:
-AndroidSDKs experimental -AndroidSDKArchitectures aarch64 -WindowsSDKs default,experimental -WindowsSDKArchitectures arm64,x64
utils/build-windows-toolchain.bat
Outdated
| -BinaryCache %BuildRoot% ^ | ||
| -ImageRoot %BuildRoot% ^ | ||
| %SkipPackagingArg% ^ | ||
| %SkipExperimentalSDKArg% ^ |
There was a problem hiding this comment.
No, we cannot skip these in this test. This is used for the PR testing and we want to maintain that these are tested - they build differently and are very easy to regress because they are building static libraries.
There was a problem hiding this comment.
Just to clarify: we would only deactivate this when running the lldb specific bots. The current Swift PR bots would still run those tests. Nothing would change for the current bots, it would only affect the new bots.
|
BTW, this is an older idea: #81790 was an initial attempt to do part of what this wants. I think I can possibly put up a partial PoC that you can help drive and use for the purposes of tweaking the LLDB tests. |
|
#83496 is something that I am playing around with - I think that is a better approach than this. It allows us to disable the default SDK and only build the experimental SDK instead! It will need a little bit more work before it can be merged, but it should be a good starting point. |
charles-zablit
force-pushed
the
charles-zablit/windows/add-optional-skip-experimental-sdk
branch
from
27fdeb7 to
b402160
Compare
charles-zablit
changed the title
There was a problem hiding this comment.
Is this going to be temporary? I would prefer that we track an issue to remove this. I am waiting on swiftlang/swift-installer-scripts#456 to get merged so I can remove the legacy SDK build.
Personally, I don't think that this is worth adding - this is going to be going away pretty soon.
Thanks! I didn't know about swiftlang/swift-installer-scripts#456. I will close this PR. |
2 participants
This patch adds a parameter to pick which SDK version to build in
build-windows-toolchain.bat.We are deploying a bot to build and test Swift features of lldb on Windows. The total run time is currently 2h15. Removing the experimentalSDK build would bring that run time to 1h50, which is a 20% speedup.