IRGen: Use C compatible representation for @cdecl enums
#83814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymus
requested review from
Xazax-hun,
egorzhdan,
fahadnayyar,
hborla,
j-hui,
rjmccall,
slavapestov,
susmonteiro,
xedin and
zoecarver
as code owners
Contributor
Author
|
@swift-ci Please smoke test |
Xazax-hun
approved these changes
Aug 19, 2025
DougGregor
reviewed
Aug 19, 2025
include/swift/AST/Decl.h
Outdated
Member
There was a problem hiding this comment.
There are 4 places where we're checking "isObjC or isCDeclEnum". Can we coalesce those into a single "is C-compatible enum" predicate?
Contributor
Author
There was a problem hiding this comment.
Good idea, I added a isCCompatibleEnum for this. Most of the implementation is shared between @cdecl and @objc enums so most call sites use this new service.
xymus
force-pushed
the
cdecl-enum-layout
branch
from
cae0575 to
a8cf1a4
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce using the raw type of
@cdeclenums for their memory layout. This brings the same behavior to@cdeclenum as what we have for@objcenums.Resolves #83738