No floating promises #1576
Merged
No floating promises #1576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
award999
added
the
full-test-run
award999
force-pushed
the
no-floating-promises
branch
from
1c990c3 to
130fa4d
Compare
plemarquand
approved these changes
May 22, 2025
award999
force-pushed
the
no-floating-promises
branch
2 times, most recently
from
83ed1fc to
9cfbf0d
Compare
We have a lot of floating promises in our code, some explicitly so, others likely being oversights. Will add a new eslint rule to watch for floating promises, fixing some and using "void" to ignore the others.
award999
force-pushed
the
no-floating-promises
branch
3 times, most recently
from
72266ae to
cf3432a
Compare
award999
force-pushed
the
no-floating-promises
branch
from
cf3432a to
aebd9b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of floating promises in our code, some explicitly so, others likely being oversights. Will add a new eslint rule to watch for floating promises, fixing some and using "void" to ignore the others.