Skip to content

Try to renable expectation for plugin output #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025
Merged

Try to renable expectation for plugin output #1645

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71d8d83
Try to renable expectation for plugin output
award999 Jun 25, 2025
524d862
Revert debugging
award999 Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/integration-tests/tasks/SwiftPluginTaskProvider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ import {
folderInRootWorkspace,
updateSettings,
} from "../utilities/testutilities";
import { executeTaskAndWaitForResult, waitForEndTaskProcess } from "../../utilities/tasks";
import {
cleanOutput,
executeTaskAndWaitForResult,
waitForEndTaskProcess,
} from "../../utilities/tasks";
import { mutable } from "../../utilities/types";
import { SwiftExecution } from "../../../src/tasks/SwiftExecution";
import { SwiftTask } from "../../../src/tasks/SwiftTaskProvider";
Expand Down Expand Up @@ -209,11 +213,7 @@ suite("SwiftPluginTaskProvider Test Suite", function () {
);
const { exitCode, output } = await executeTaskAndWaitForResult(task);
expect(exitCode, output).to.equal(0);
// TODO figure out why the output is '' intermittently
// it seems like the task is being copied by any of the
// vscode.tasks event emitters so executeTaskAndWaitForResult
// captures no output
// expect(cleanOutput(output)).to.include("Hello, World!");
expect(cleanOutput(output)).to.include("Hello, World!");
});

test("Exit code on failure", async () => {
Expand Down