[stdlib] Fix calling convention mismatch for debugger utility functions #5506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions `swift_retainCount`, `swift_unownedRetainCount`, and `swift_weakRetainCount` are declared in `HeapObject.h` as using the C calling convention, but the Swift declarations referenced them by `@_silgen_name`, which uses the Swift calling convention. This patch fixes the mismatch without any ABI/API breakage by calling the utility functions through C interop.
kateinoigakukun
force-pushed
the
katei/cherry-pick-to-downstream/heapobject-cc-violation
branch
from
65af10a to
e3b2c44
Compare
kateinoigakukun
deleted the
katei/cherry-pick-to-downstream/heapobject-cc-violation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick 8addaa1