-
-
Notifications
You must be signed in to change notification settings - Fork 504
Add recipes for symfonycasts/sass-bundle #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
makraz
commented
Jan 1, 2024
| Q | A |
|---|---|
| License | MIT |
| Doc issue/PR | symfony/symfony-docs#... |
|
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
Head branch was pushed to by a user without write access
|
@weaverryan Can you review this one please? |
|
It looks like there is a space in the path of Is that intended? |
Head branch was pushed to by a user without write access
good catch, thank you, I fixed it 👍🏼 |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
| @@ -0,0 +1,3 @@ | |||
| body { | |||
| background-color: skyblue; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we do the same in AssetMapper (see https://github.com/symfony/recipes/blob/main/symfony/asset-mapper/6.4/assets/styles/app.css) but wouldn't it be better to ship with an empty file? Maybe add some comment (using SASS format, to verify that this is working). For example:
// add your SASS styles in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javiereguiluz I made the update 🙌🏼
Head branch was pushed to by a user without write access