Skip to content

Conversation

@makraz
Copy link
Contributor

@makraz makraz commented Jan 1, 2024

Q A
License MIT
Doc issue/PR symfony/symfony-docs#...

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) January 1, 2024 14:49
@github-actions
Copy link

github-actions bot commented Jan 1, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1278/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1278/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'symfonycasts/sass-bundle:^0.5'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled January 1, 2024 18:15

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) January 1, 2024 18:15
@fabpot
Copy link
Member

fabpot commented Jan 18, 2024

@weaverryan Can you review this one please?

@OskarStark OskarStark requested a review from weaverryan January 18, 2024 08:38
@rosier
Copy link
Contributor

rosier commented Feb 8, 2024

It looks like there is a space in the path of symfonycasts/sass-bundle/0.4/assets /styles/app.scss at the end of assets.

Is that intended?

auto-merge was automatically disabled February 8, 2024 18:19

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 8, 2024 18:20
@makraz
Copy link
Contributor Author

makraz commented Feb 8, 2024

It looks like there is a space in the path of symfonycasts/sass-bundle/0.4/assets /styles/app.scss at the end of assets.

Is that intended?

good catch, thank you, I fixed it 👍🏼

auto-merge was automatically disabled February 8, 2024 18:32

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 8, 2024 18:32
auto-merge was automatically disabled February 8, 2024 18:36

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 8, 2024 18:37
auto-merge was automatically disabled February 8, 2024 18:41

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 8, 2024 18:42
@@ -0,0 +1,3 @@
body {
background-color: skyblue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we do the same in AssetMapper (see https://github.com/symfony/recipes/blob/main/symfony/asset-mapper/6.4/assets/styles/app.css) but wouldn't it be better to ship with an empty file? Maybe add some comment (using SASS format, to verify that this is working). For example:

// add your SASS styles in this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javiereguiluz I made the update 🙌🏼

auto-merge was automatically disabled November 4, 2025 11:31

Head branch was pushed to by a user without write access

@makraz makraz requested a review from javiereguiluz November 4, 2025 11:31
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 4, 2025 11:31
@symfony-recipes-bot symfony-recipes-bot merged commit f7f22c6 into symfony:main Nov 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants