Skip to content

Conversation

@neothone
Copy link

Q A
License MIT

This recipe (and the pack behind it) is almost the same of the alias webapp of symfony/webapp-pack : the difference is usage of Webpack Encore versus AssetMapper.

This recipe interest is alias and in recipes-contrib there aren't aliases.

This is offering an alternative to compose require webapp with compose require webapp-webpack-encore.

This will prevent:

composer create-project symfony/skeleton:"7.3.x" my_project_directory
composer require webapp
composer remove symfony/ux-turbo symfony/asset-mapper symfony/stimulus-bundle
composer require symfony/webpack-encore-bundle symfony/ux-turbo symfony/stimulus-bundle

And improves the developer experience :

composer create-project symfony/skeleton:"7.3.x" my_project_directory
composer require webapp-webpack-encore

And we can clearly offering the three solutions (without webapp, with webapp and with webapp-webpack-encore) in the Creating Symfony Applications documentation

Copilot AI review requested due to automatic review settings October 10, 2025 20:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new alias "webapp-webpack-encore" for the fastfony/webapp-webpack-encore-pack to provide an alternative to the existing webapp pack that uses Webpack Encore instead of AssetMapper.

  • Creates a new manifest.json file with the webapp-webpack-encore alias
  • Enables developers to use composer require webapp-webpack-encore as a shortcut
  • Improves developer experience by eliminating the need to manually swap AssetMapper components for Webpack Encore

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 10, 2025 20:12
@github-actions
Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1461/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1461/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'fastfony/webapp-webpack-encore-pack:^1.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@Kocal
Copy link
Member

Kocal commented Oct 11, 2025

What if we want to provide an official webapp pack based on Webpack Encore?

@neothone
Copy link
Author

What if we want to provide an official webapp pack based on Webpack Encore?

Good news!

It will replace this?

And, it's very easy to do copy/paste this: https://github.com/fastfony/webapp-webpack-encore-pack/blob/main/composer.json

@chalasr
Copy link
Member

chalasr commented Oct 11, 2025

As per

This repository contains "official" recipes for Composer packages endorsed by the Symfony Core Team. For contributed recipes, see the contrib repository.

Packages from the fastfony organization do not qualify as official recipes at the moment, so this PR cannot be merged. Thank you for proposing.

@chalasr chalasr closed this Oct 11, 2025
auto-merge was automatically disabled October 11, 2025 10:10

Pull request was closed

@neothone
Copy link
Author

😞

@neothone
Copy link
Author

@chalasr I'm disappointed. I try to contribute with a simple thing and this pull request can improve Developer Experience.

-1 votes must always be justified by technical and objective reasons;

"the fastfony organization do not qualify as official recipes at the moment"

It is not a technical and objective reason.
And you don't say how to become "qualify as official". What are the criteria? I'm ready to try...

Too, in the README that you quote, official is in between quotes. It's like sentence which is finish by "..." : it means everything and nothing!

I have no problem with the idea of fastfony organization appears or no. I can too recreate with my GH username. I just want contribute and improve the developer experience!

I will be happy if a symfony/webapp-webpack-encore-bundle is created! Let's find a solution.

@nicolas-grekas
Copy link
Member

I get your disappointment. I also don't think adding the alias would significantly change the overall DX so it's not a big issue to me. It also prevents us from endorsing the pack as official (since as you hinted, the term official is ours to define, and merging is the way to show endorsement.)

@neothone
Copy link
Author

Then I suggest closing the public contributions on this repository!

@nicolas-grekas
Copy link
Member

This doesn't make any sense sorry.
BTW, I meant "prevents us from endorsing the pack as official" in a positive way: there's no need for something to be stated as "official" for it to be useful and widely used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants