-
-
Notifications
You must be signed in to change notification settings - Fork 504
Add alias webapp-webpack-encore #1461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new alias "webapp-webpack-encore" for the fastfony/webapp-webpack-encore-pack to provide an alternative to the existing webapp pack that uses Webpack Encore instead of AssetMapper.
- Creates a new manifest.json file with the webapp-webpack-encore alias
- Enables developers to use
composer require webapp-webpack-encoreas a shortcut - Improves developer experience by eliminating the need to manually swap AssetMapper components for Webpack Encore
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
|
What if we want to provide an official webapp pack based on Webpack Encore? |
Good news! It will replace this? And, it's very easy to do copy/paste this: https://github.com/fastfony/webapp-webpack-encore-pack/blob/main/composer.json |
|
As per
Packages from the fastfony organization do not qualify as official recipes at the moment, so this PR cannot be merged. Thank you for proposing. |
Pull request was closed
|
😞 |
|
@chalasr I'm disappointed. I try to contribute with a simple thing and this pull request can improve Developer Experience.
It is not a technical and objective reason. Too, in the README that you quote, official is in between quotes. It's like sentence which is finish by "..." : it means everything and nothing! I have no problem with the idea of fastfony organization appears or no. I can too recreate with my GH username. I just want contribute and improve the developer experience! I will be happy if a symfony/webapp-webpack-encore-bundle is created! Let's find a solution. |
|
I get your disappointment. I also don't think adding the alias would significantly change the overall DX so it's not a big issue to me. It also prevents us from endorsing the pack as official (since as you hinted, the term official is ours to define, and merging is the way to show endorsement.) |
|
Then I suggest closing the public contributions on this repository! |
|
This doesn't make any sense sorry. |
This recipe (and the pack behind it) is almost the same of the alias webapp of symfony/webapp-pack : the difference is usage of Webpack Encore versus AssetMapper.
This recipe interest is alias and in recipes-contrib there aren't aliases.
This is offering an alternative to
compose require webappwithcompose require webapp-webpack-encore.This will prevent:
And improves the developer experience :
And we can clearly offering the three solutions (without webapp, with webapp and with webapp-webpack-encore) in the Creating Symfony Applications documentation